-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add option to customize types/scopes to exclude #103
base: main
Are you sure you want to change the base?
Conversation
Thanks for this PR (and sorry took too long to review!). I like the idea. Only thinking to find a better option namespace so that we could include more configurations like this about changelog filtering without adding too many top level options (ideas welcome!) |
Hey @pi0, thanks for reverting! Do you have any idea of such typical cases? I proposed this specific option because Well in that case one could think of something like We could also think about:
What are your thoughts? |
8af9a19
to
27d60dd
Compare
bc9b77d
to
d3d1400
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
===========================================
- Coverage 69.10% 47.10% -22.00%
===========================================
Files 9 12 +3
Lines 916 1002 +86
Branches 85 101 +16
===========================================
- Hits 633 472 -161
- Misses 283 527 +244
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. |
Hey @pi0, I am back on this one with a proposal which generalizes my original PR as requested. The new option
Let me know what you think :) |
This would be useful! |
7bc0aa2
to
c751676
Compare
The current version of
changelogen
(great piece of work by the way <3) seems opinionated, as it hard codes the exclusion of chore(deps) from changelogs by filtering parsed commits:changelogen/src/commands/default.ts
Lines 34 to 38 in db1c625
I like to keep track of the history of my dependencies, so I would like to have the possibility to include those commits in the generated changelog. This is what this PR enables, with an new config option,
excludeChoreDeps
which defaults totrue
as being the current behavior.In order to add a corresponding test (with both boolean values of the option), I've decided to export a new function,
filterParsedCommits
, which I can import in the test file and run tests on it.I hope that is acceptable 😃