Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --publish and --canary #123

Merged
merged 10 commits into from
Jul 3, 2023
Merged

feat: support --publish and --canary #123

merged 10 commits into from
Jul 3, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 3, 2023

πŸ”— Linked issue

resolves #105

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds support for --edge and --publish flags when passed on CI to do something like:

npx changelogen --publish --edge

It will automatically enable provenance if running in GitHub Actions, and will bump package version appropriately.

Feedback (and direct edits!) welcome.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Jul 3, 2023
@danielroe danielroe requested a review from pi0 July 3, 2023 14:10
@danielroe danielroe self-assigned this Jul 3, 2023
@danielroe danielroe force-pushed the feat/edge-release branch from 283b3ee to 3164854 Compare July 3, 2023 14:17
@pi0 pi0 changed the title feat: add support for publishing + edge releases feat: add support for --edge and --publish Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #123 (af379ee) into main (d5d8455) will decrease coverage by 2.92%.
The diff coverage is 43.15%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   71.55%   68.63%   -2.92%     
==========================================
  Files           7        9       +2     
  Lines         798      880      +82     
  Branches       81       81              
==========================================
+ Hits          571      604      +33     
- Misses        227      276      +49     
Impacted Files Coverage Ξ”
src/semver.ts 26.13% <13.33%> (-2.62%) ⬇️
src/package.ts 29.31% <29.31%> (ΓΈ)
src/config.ts 95.28% <100.00%> (+0.49%) ⬆️
src/exec.ts 100.00% <100.00%> (ΓΈ)
src/git.ts 83.76% <100.00%> (-0.52%) ⬇️

src/semver.ts Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Jul 3, 2023

Thanks πŸš€ I have quickly iterated to make some refactors, mainly to introduce this feature as (more generic) name/version suffix options to internal utils. Also introducing feature (CLI shortcut) as (more known) --canary with the ability to set --canary edge to be more similar to Nuxt/UnJS edge channels via one command.

@pi0 pi0 changed the title feat: add support for --edge and --publish feat: add support for --canary and --publish Jul 3, 2023
@pi0 pi0 changed the title feat: add support for --canary and --publish feat: support --publish and --canary Jul 3, 2023
@danielroe
Copy link
Member Author

Looks great! ❀️

@pi0 pi0 merged commit 1e5f0b7 into main Jul 3, 2023
@pi0 pi0 deleted the feat/edge-release branch July 3, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --publish flag
2 participants