Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repo option as string #128

Merged
merged 1 commit into from
Aug 22, 2023
Merged

feat: repo option as string #128

merged 1 commit into from
Aug 22, 2023

Conversation

Waleed-KH
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allow the repo option to be string, and then resolve it with getRepoConfig

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #128 (65106e0) into main (1b5fa2d) will increase coverage by 0.43%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   68.63%   69.06%   +0.43%     
==========================================
  Files           9        9              
  Lines         880      902      +22     
  Branches       81       83       +2     
==========================================
+ Hits          604      623      +19     
- Misses        276      279       +3     
Impacted Files Coverage Ξ”
src/github.ts 18.75% <10.00%> (ΓΈ)
src/config.ts 93.44% <88.46%> (-1.85%) ⬇️
src/markdown.ts 97.23% <100.00%> (+0.04%) ⬆️
src/repo.ts 95.90% <100.00%> (+0.10%) ⬆️

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ’―

@pi0 pi0 merged commit 46f60cc into unjs:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants