Skip to content

Conversation

@PKief
Copy link
Contributor

@PKief PKief commented May 3, 2025

Follow up of #247, resolves #246

This PR improves the configuration of the hideAuthorEmail flag to make it work correctly. Before the flag was not properly applied to the logic. The PR also adds a test to ensure that it works.

@codecov
Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (0914fd7) to head (a126374).
Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/default.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #275       +/-   ##
===========================================
- Coverage   69.10%   45.88%   -23.23%     
===========================================
  Files           9       12        +3     
  Lines         916      996       +80     
  Branches       85      102       +17     
===========================================
- Hits          633      457      -176     
- Misses        283      537      +254     
- Partials        0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0 pi0 changed the title feat: add hideAuthorEmail option to skip author email addresses fix(cli): accept hideAuthorEmail arg Jul 6, 2025
@pi0 pi0 merged commit cd1f491 into unjs:main Jul 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Optionally hide email addresses for authors

2 participants