Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github release integration #67

Merged
merged 20 commits into from
Mar 3, 2023
Merged

feat: github release integration #67

merged 20 commits into from
Mar 3, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 1, 2023

Usage:

changelogen gh release <versions...>

(more usage is updated in the docs)

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #67 (f10676c) into main (a5ab510) will decrease coverage by 10.69%.
The diff coverage is 46.07%.

@@             Coverage Diff             @@
##             main      #67       +/-   ##
===========================================
- Coverage   84.07%   73.39%   -10.69%     
===========================================
  Files           6        7        +1     
  Lines         559      733      +174     
  Branches       80       86        +6     
===========================================
+ Hits          470      538       +68     
- Misses         89      195      +106     
Impacted Files Coverage Δ
src/github.ts 19.11% <19.11%> (ø)
src/config.ts 93.54% <100.00%> (+1.78%) ⬆️
src/index.ts 100.00% <100.00%> (ø)
src/markdown.ts 97.19% <100.00%> (+0.59%) ⬆️
src/repo.ts 100.00% <100.00%> (ø)
src/git.ts 88.66% <0.00%> (+1.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atinux
Copy link
Member

atinux commented Mar 3, 2023

Beautiful 💯

I still like the idea of open GitHub to create/update the release so you don't even need to ask user for a GitHub token

@pi0
Copy link
Member Author

pi0 commented Mar 3, 2023

Agreed it is not always convinient to require a token!

We have two ideas:

  • Show link to open GitHub create release page with prefilled contents if there is no token (not in this PR)
  • A GitHub action that syncs the release (Generates changelog to GitHub Releases in Actions #32) which can built on the same sync feature and auto-provided github token in the action

Copy link
Member

atinux commented Mar 3, 2023

Show link to open GitHub create release page with prefilled contents if there is no token (not in this PR)

Release it open the link in browser directly but I like the idea of showing the url :)

GitHub action is a nice idea as well but will need documenting

@pi0
Copy link
Member Author

pi0 commented Mar 3, 2023

Thanks for the feedback and ideas! I have added a fallback mechanism for manual release:

image

@pi0 pi0 changed the title feat: github release sync feat: github release utils and sub command Mar 3, 2023
@pi0 pi0 marked this pull request as ready for review March 3, 2023 15:07
@pi0 pi0 changed the title feat: github release utils and sub command feat: github release integration Mar 3, 2023
@pi0
Copy link
Member Author

pi0 commented Mar 3, 2023

Man, i love this PR 😆

image

@pi0 pi0 merged commit acf06a0 into main Mar 3, 2023
@pi0 pi0 deleted the feat/gh_releases branch March 3, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants