Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strict args #149

Closed
wants to merge 2 commits into from
Closed

fix: strict args #149

wants to merge 2 commits into from

Conversation

Teages
Copy link

@Teages Teages commented Jun 4, 2024

πŸ”— Linked issue

#148

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #148

I noticed that citty didn't provide null-safety on context.args even strict is true, this will break some type checks. In this pr I make all args be nullable first, then make required and items with default values ​​non-nullable.

And ParsedArgs type has some errors when parsing enum, it just return the options array itself but the correct should be the type of items in the array. In this pr I just simplly fixed it, but the best fix should make the type more precise.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly. (N/A)

@Teages
Copy link
Author

Teages commented Jun 4, 2024

oops I just noticed #132, sorry to bother you :(

@Teages Teages closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error on arguments
1 participant