Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgresql): use default export #63

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

amandesai01
Copy link
Contributor

πŸ”— Linked issue

Resolves #62

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Updated import statement for "pg" so that is works well with *.mjs files.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@fsyntax

This comment was marked as off-topic.

@amandesai01
Copy link
Contributor Author

can we merge this? need this in a project.

@pi0
Copy link
Member

pi0 commented Apr 24, 2024

sorry for delay but i need further testing to see either prefer this or import * as syntax (i understand it fixes nitro builds)

in the meantime i suggest to use pnpm patch.

@BlueBazze

This comment was marked as off-topic.

@danielroe danielroe requested review from pi0 and removed request for pi0 June 7, 2024 15:12
@danielroe

This comment was marked as off-topic.

@rafaelmagalhaes

This comment was marked as off-topic.

@CrazyWords1

This comment was marked as off-topic.

@joerosenthal
Copy link

Any updates on this? Currently having issues with using pg in a nuxt3 project on the nitro side of thingsβ€”same failure to import: "The requested module 'pg' does not provide an export named 'Client'"

@BlueBazze
Copy link

Any updates on this? Currently having issues with using pg in a nuxt3 project on the nitro side of thingsβ€”same failure to import: "The requested module 'pg' does not provide an export named 'Client'"

Based on what I've seen and read.
Yes, pg is unusable until this is fixed. But keep in mind that it is an experimental feature, so it probably has a low priority.
Especially since they are in the middle of releasing nitro 3.0, and nuxt is working on nuxt 4.0
Nitro 3.0 was planned for the middle of june or july, so pi0 is likely working that.

@TimvdEijnden
Copy link

TimvdEijnden commented Sep 10, 2024

I also wanted to use db0 with postgres, but this is blocking me. @pi0 can you help a fellow Passionate Person πŸ˜‰

@pi0 pi0 changed the title fix(connectors): update import to work with esm refactor(postgresql): use default export Oct 9, 2024
@pi0 pi0 changed the title refactor(postgresql): use default export fix(postgresql): use default export Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@903e1a0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/connectors/postgresql.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage        ?   29.90%           
=======================================
  Files           ?       15           
  Lines           ?      515           
  Branches        ?       43           
=======================================
  Hits            ?      154           
  Misses          ?      354           
  Partials        ?        7           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Oct 9, 2024

Thanks for fix PR and sorry it got this delayed. db0 was experimental and took less priority. it will get better attention.

@pi0 pi0 merged commit 8b29f52 into unjs:main Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres connector: The requested module 'pg' does not provide an export named 'Client'
9 participants