-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve log when using alternative port #78
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 85.45% 85.56% +0.11%
==========================================
Files 5 5
Lines 385 388 +3
Branches 50 51 +1
==========================================
+ Hits 329 332 +3
Misses 56 56 β View full report in Codecov by Sentry. |
src/get-port.ts
Outdated
"-", | ||
)} ${_fmtOnHost( | ||
options.host, | ||
)}). Using alternative port ${availablePort}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move availablePort
check part to partially remove last part of the message?
@pi0 There seems to be a flakey test, FYI. Latest commit passes with no code changes compared to previous failure. Maybe we could increase timeout? π€ |
π Linked issue
β Type of change
π Description
This no longer logs if an empty array is passed in
portsToCheck
, and also corrects the log message so it doesn't say that it failed to find a port in the range that did produce a port.π Checklist