Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve log when using alternative port #78

Merged
merged 6 commits into from
Jan 9, 2024
Merged

fix: improve log when using alternative port #78

merged 6 commits into from
Jan 9, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This no longer logs if an empty array is passed in portsToCheck, and also corrects the log message so it doesn't say that it failed to find a port in the range that did produce a port.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 January 4, 2024 16:07
@danielroe danielroe self-assigned this Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (2ff49d5) 85.45% compared to head (e394270) 85.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   85.45%   85.56%   +0.11%     
==========================================
  Files           5        5              
  Lines         385      388       +3     
  Branches       50       51       +1     
==========================================
+ Hits          329      332       +3     
  Misses         56       56              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

src/get-port.ts Outdated
"-",
)} ${_fmtOnHost(
options.host,
)}). Using alternative port ${availablePort}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move availablePort check part to partially remove last part of the message?

@pi0 pi0 changed the title chore: improve log when using alternative port fix: improve log when using alternative port Jan 4, 2024
@danielroe danielroe requested a review from pi0 January 4, 2024 22:35
@danielroe
Copy link
Member Author

@pi0 There seems to be a flakey test, FYI. Latest commit passes with no code changes compared to previous failure. Maybe we could increase timeout? πŸ€”

@danielroe danielroe requested review from pi0 and removed request for pi0 January 9, 2024 10:09
@pi0 pi0 merged commit a7c041c into main Jan 9, 2024
4 checks passed
@pi0 pi0 deleted the fix/port-log branch January 9, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants