Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cloning from http(s) inputs #129

Merged
merged 1 commit into from
Dec 23, 2023
Merged

feat: support cloning from http(s) inputs #129

merged 1 commit into from
Dec 23, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 23, 2023

πŸ”— Linked issue

resolves #10

previous works #86, #91 ❀️

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds support for input to using http:// or https:// protocols.

If the path ends with .json or a response content type with HEAD method is application/json or text/plain for the sake of GH raw content (reverted in 1945818), we download JSON as Template info.

Otherwise we try to guess name from URL's last segment (basename) or content-disposition filename header if provided in HEAD response as default name.

The fragment support as proposed in initial issue is not implemented as I think with JSON support now we have enough power to control responses without making inputs more complex but PR welcome if there are valid cases for it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit cb82386 into main Dec 23, 2023
2 checks passed
pi0 added a commit that referenced this pull request Dec 23, 2023
@pi0 pi0 deleted the feat/http-source branch December 23, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built-in tar: provider
1 participant