feat: support cloning from http(s) inputs #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #10
previous works #86, #91 β€οΈ
β Type of change
π Description
This PR adds support for input to using
http://
orhttps://
protocols.If the path ends with
.json
or a response content type withHEAD
method isapplication/json
or(reverted in 1945818), we download JSON as Template info.text/plain
for the sake of GH raw contentOtherwise we try to guess name from URL's last segment (basename) or
content-disposition
filename
header if provided inHEAD
response as default name.The fragment support as proposed in initial issue is not implemented as I think with JSON support now we have enough power to control responses without making inputs more complex but PR welcome if there are valid cases for it.
π Checklist