Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subdir filter for dirs with shared prefix #14

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Sep 14, 2022

You want to download unjs/templates/vue, but there are two templates under unjs/templates that start with vue (vue and vue-ts). At this point you will get a wrong template

vue
└── -ts

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #14 (374104a) into main (24e34d4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   69.14%   69.14%           
=======================================
  Files           6        6           
  Lines         269      269           
  Branches       36       36           
=======================================
  Hits          186      186           
  Misses         83       83           
Impacted Files Coverage Δ
src/giget.ts 75.92% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pi0 pi0 changed the title fix: multiple templates with the same prefix fix: subdir filter for dirs with shared prefix Sep 14, 2022
@pi0 pi0 merged commit c6ab563 into unjs:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants