Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct gitlab repository path #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sl0wik
Copy link

@sl0wik sl0wik commented Jan 10, 2024

πŸ”— Linked issue

#107

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Gitlab supports nested subgroups, like https://gitlab.com/{groupName}/{subgroupName}/{repoName}. Attempting to pull any subgroup would result in a 403 error. This pull request resolves the issue.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (81c9429) 54.63% compared to head (14561ec) 54.63%.

Files Patch % Lines
src/providers.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files           7        7           
  Lines         615      615           
  Branches       47       47           
=======================================
  Hits          336      336           
  Misses        278      278           
  Partials        1        1           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Mar 21, 2024

Hi. Sorry for delay on this. I mainly wanted to double check if both with and without subgroups it works and didn't had a chance to make a testing gitlab structure yet. If you have some it can be helpful to speedup landing this πŸ™πŸΌ

@kovaletsyurii-hue
Copy link

kovaletsyurii-hue commented May 2, 2024

Hi @sl0wik . Thanks for that fix. It helps me a lot. To be compatible with the latest giget version v1.2.3 your fix need to be updated a little:
url: `${gitlab2}/${parsed.repo}${parsed.subdir}/tree/${parsed.ref}`,
tar: `${gitlab2}/${parsed.repo}${parsed.subdir}/-/archive/${parsed.ref}.tar.gz`,

@younho9
Copy link

younho9 commented Oct 22, 2024

When subdir is used as a subgroup, an error occurs when extract using tar.

The subgroup must be included in the repo regular expression.

@simon-kramer
Copy link

Is the solution already in the release and adapted e.g. by Nuxt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants