Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use inline require cache to avoid circular dependencies #125

Merged
merged 3 commits into from
Mar 6, 2023
Merged

fix: use inline require cache to avoid circular dependencies #125

merged 3 commits into from
Mar 6, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 6, 2023

resolves #124
resolves unjs/c12#58

When requireCache is disabled, we still need an object to track circular dependencies. The new object will be passed by jiti calls but in same session and invalidated after tree evaluation.

@pi0 pi0 changed the title fix/require circular @pi0 fix: use inline require cache when requireCache disabled Mar 6, 2023
@pi0 pi0 changed the title @pi0 fix: use inline require cache when requireCache disabled fix: use inline require cache when requireCache disabled Mar 6, 2023
@pi0 pi0 changed the title fix: use inline require cache when requireCache disabled fix: use inline require cache to avoid circular dependencies Mar 6, 2023
@pi0 pi0 merged commit 55b9935 into main Mar 6, 2023
@pi0 pi0 mentioned this pull request May 24, 2023
Closed
@pi0 pi0 deleted the fix/require-circular branch May 24, 2023 14:04
@pi0 pi0 mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@pi0