Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support import.meta.env and import.meta.env?.prop #159

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 18, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently, we support import.meta.env.foobar by replacing AST to process.env.foobar but using import.meta.env itself was not possible and could possibly make issues like cannot use import outside of a module.

This PR also adds support for import.meta.env? with optional chaining, increases type safety and simplifies code.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 7155c00 into main Aug 18, 2023
@pi0 pi0 deleted the fix/import-meta-env branch August 18, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant