Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow configuring all esbuild transform #1347

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix: allow configuring all esbuild transform #1347

merged 2 commits into from
Jun 28, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#21756

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently it's not possible to configure the esbuild plugin more generally. (The tsconfig option is completely ignored, for example.) This is a small change to enable configuring the options passed to transform. I've tried to keep behaviour as close to current as possible but we may want instead to rework this plugin.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 25, 2023
@danielroe danielroe requested a review from pi0 June 25, 2023 20:01
@danielroe danielroe self-assigned this Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1347 (665b5a8) into main (e3f817e) will decrease coverage by 0.03%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   76.61%   76.58%   -0.03%     
==========================================
  Files          71       71              
  Lines        7232     7223       -9     
  Branches      718      718              
==========================================
- Hits         5541     5532       -9     
  Misses       1690     1690              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/rollup/plugins/esbuild.ts 76.33% <86.36%> (-1.53%) ⬇️

@pi0 pi0 changed the title fix: allow configuring esbuild transform plugin feat: allow configuring esbuild transform plugin Jun 26, 2023
@pi0 pi0 removed the bug Something isn't working label Jun 26, 2023
@pi0 pi0 changed the title feat: allow configuring esbuild transform plugin fix: allow configuring all esbuild transform Jun 28, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: While this fix/feature allows to override tsconfig and target directly, this is not something i would recommend or advice or that we might always support for users to set and should be determined by nuxt/nitro framework and presets.

@pi0 pi0 merged commit 126574d into main Jun 28, 2023
@pi0 pi0 deleted the fix/esbuild-options branch June 28, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants