Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not call addDependency with empty array #147

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix: do not call addDependency with empty array #147

merged 2 commits into from
Aug 25, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe added the bug Something isn't working label Aug 25, 2024
@danielroe danielroe requested a review from pi0 August 25, 2024 19:26
@danielroe danielroe self-assigned this Aug 25, 2024
pi0
pi0 reviewed Aug 25, 2024
View reviewed changes
src/api.ts Show resolved Hide resolved
pi0
pi0 approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx!

@pi0 pi0 merged commit f2b460c into main Aug 25, 2024
0 of 4 checks passed
@pi0 pi0 deleted the fix/empty-deps branch August 25, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: package fails to install
2 participants
@danielroe @pi0