fix(resolveAlias): handle aliases ending with trailing slash

[huang-julien]

🔗 Linked issue

resolve #154

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR fix resolveAlias's pathSeperator check by verifying if the alias ends with / or \

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[danielroe]

What about alternatively stripping trailing-slashes in normalizeAliases?

[pi0]

The only possible downside I can think with stripping trailing slash is then made npm-package (main import) and npm-package/ (all subpath exports) for when normalizeAliases util will be used. Would only normalizing backslash in aliases also worked? (haven't tried PR locally yet)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dffa918) 99.42% compared to head (9aeeee2) 99.44%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   99.42%   99.44%   +0.02%     
==========================================
  Files           4        4              
  Lines         346      359      +13     
  Branches      106      111       +5     
==========================================
+ Hits          344      357      +13     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielroe]

I think we already handle that via ordering of aliases (we sort them).

[pi0]

What if one wants to only alias main package or it's subpaths? By removing there is no longer a way to distinguish even if sorted.

[danielroe]

you're right that we no longer have a way to alias only subpaths, though I think aliasing only main package would work same way either way.

[huang-julien]

should we leave it like that ?

[pi0]

I have added a few more tests for mixed situations (aliases provided both for with trailing slash and without) and also did some refactors to resolveAlias mainly to make logic readable (impl change is same as original PR).

With these changes, could quickly check if we remove the trailing slash of the alias while slicing in L54 (simply change alias to _alias without trailing, and it fails), while the current fix only checks alias prefix without trailing slash for condition and uses original alias preserving this.