Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stringify strings to avoid being cast to numbers #123

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: stringify strings to avoid being cast to numbers #123

merged 1 commit into from
Apr 9, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This ensures we stringify strings to avoid them being cast back to numbers when they are read (e.g. 021324)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 9, 2024
@danielroe danielroe requested a review from pi0 April 9, 2024 16:07
@danielroe danielroe self-assigned this Apr 9, 2024
@pi0 pi0 merged commit de02f94 into main Apr 9, 2024
1 check failed
@pi0 pi0 deleted the fix/stringify-strings branch April 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0