fix(matchAll): sort routes with same type #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
pi0
added a commit
to nuxt/nuxt.com
that referenced
this pull request
Mar 27, 2023
hotfix before unjs/rou3#45
danielroe
pushed a commit
to nuxt/nuxt.com
that referenced
this pull request
Oct 18, 2023
hotfix before unjs/rou3#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #44
The return value of
matchAllnormally should return from less specific to most specific matches (wildcard > params > static). However when checking same kind of rules, like between wildcards, we was not sorting them. Comparing by length as simplest possible workaround we might improve it later if there was more edge cases when comparing same type.