feat: detect the underlying runtime #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Aug 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 82.88% 86.02% +3.13%
==========================================
Files 6 7 +1
Lines 263 322 +59
Branches 25 29 +4
==========================================
+ Hits 218 277 +59
Misses 42 42
Partials 3 3
|
pi0
approved these changes
Aug 16, 2023
paperclover
reviewed
Aug 16, 2023
| // https://nodejs.org/api/process.html#processrelease | ||
| export const isLagon = !!globalThis.__lagon__; | ||
| export const isNode = globalThis.process?.release?.name === "node"; | ||
| export const isBun = globalThis.process?.release?.name === "bun"; |
There was a problem hiding this comment.
i could be mistaken but i believe we updated this property to be "node" due to a compatibility fix of an old package.
use !!globalThis.bun or !!process.versions.bun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#65
β Type of change
π Description
Port from https://github.com/QuiiBz/detect-runtime to add a new
detectRuntime()function, and newisNode,isDeno, andisBunflags.The list of runtime keys is currently limited to
workerd,deno,lagon,netlify,node,bun,edge-light, andfastlybecauseelectron,react-native, andedge-routineare not easily detectable.This PR also updates the Provider Detection section of the README to use the correct
providerandproviderInfovariables (instead ofplatformandplatformInfo)π Checklist