feat: emit close and finish events and remove listeners on destroy

unjs · Nov 19, 2020 · cc42554 · cc42554
1 parent 82dac22
commit cc42554
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src.runtime/node/stream/readable.ts b/src.runtime/node/stream/readable.ts
@@ -62,6 +62,7 @@ export class Readable extends EventEmitter implements stream.Readable {
   }
 
   _destroy (_error?: any, _callback?: Callback<any>) {
+    this.removeAllListeners()
   }
 
   destroy (error?: Error) {

diff --git a/src.runtime/node/stream/writable.ts b/src.runtime/node/stream/writable.ts
@@ -64,6 +64,8 @@ export class Writable extends EventEmitter implements stream.Writable {
     }
     this.writableEnded = true
     this.writableFinished = true
+    this.emit('close')
+    this.emit('finish')
   }
 
   cork (): void {
@@ -73,5 +75,6 @@ export class Writable extends EventEmitter implements stream.Writable {
   }
 
   destroy (_error?: Error): void {
+    this.removeAllListeners()
   }
 }