Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support returning raw body for binary content-types #43

Closed
wants to merge 4 commits into from
Closed

feat: support returning raw body for binary content-types #43

wants to merge 4 commits into from

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 29, 2022 •
edited
Loading

related downstream issue: nitrojs/nitro#100

@danielroe danielroe self-assigned this Jun 29, 2022
@danielroe danielroe added the enhancement New feature or request label Jun 29, 2022
@danielroe danielroe marked this pull request as ready for review June 29, 2022 14:06
@danielroe danielroe requested a review from pi0 June 29, 2022 14:06
@danielroe danielroe mentioned this pull request Jun 29, 2022
Merged
7 tasks
pi0
pi0 reviewed Jun 29, 2022
View reviewed changes
src/runtime/fetch/call.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 July 4, 2022 09:51
@mariocesar
Copy link

FYI, if this and nitrojs/nitro#320 is merged it will enable to deploy Nuxt.js to AWS Lambda

@danielroe danielroe mentioned this pull request Aug 13, 2022
Closed
@pi0 pi0 closed this in 8f1235f Aug 24, 2022
@pi0
Copy link
Member

pi0 commented Aug 24, 2022

Let's return _data as is and let the upper layer (fetch) or direct use intercept the body type. It has to be a breaking change but seems better fix to not assume type of _data (technically for node polyfill it should be buffer or string but we set it as is there too)

@pi0 pi0 deleted the feat/binary branch August 24, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0 pi0 is a code owner

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @mariocesar @pi0