Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose __unenv__ flag for unenv classes and functions #125

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 8, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

it is commonly required to identify if something is coming from unenv or not specially for classes and mocked objects.

This PR adds __unenv__ property to class (instances) and functions to identify.

Note: Since we were already using req.__unenv__ for another purpose (#72), the type for IncommingMessage and Readable classes is unknown/object.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@@ -1 +1,5 @@
export default {};
export default Object.freeze(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: freezing is not related to this PR but quickly included as fix

@pi0 pi0 merged commit ae04a73 into main Aug 8, 2023
2 checks passed
@pi0 pi0 deleted the feat/mark-mock branch August 8, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant