feat: support variable axes for google #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerzl
changed the title
danielroe
reviewed
Oct 6, 2024
|
Sorry - one last thing! Would you be able to write a test? 🙏 |
|
Done. Sorry for the long time. Forgot to pull your latest commit on my local machine so spent a long time figuring out why the output on my local machine is different from the output from GitHub actions.. |
danielroe
reviewed
Oct 15, 2024
test/providers/google.test.ts
Outdated
Comment on lines
45
to
48
| slnt: ['-15..0'], | ||
| CASL: ['0..1'], | ||
| CRSV: ['0..1'], | ||
| MONO: ['0..1'], |
There was a problem hiding this comment.
would it make more sense for the format to be:
Suggested change
| slnt: ['-15..0'], | |
| CASL: ['0..1'], | |
| CRSV: ['0..1'], | |
| MONO: ['0..1'], | |
| slnt: ['-15', '0'], | |
| CASL: ['0', '1'], | |
| CRSV: ['0', '1'], | |
| MONO: ['0', '1'], |
it feels like the .. joining is an implementation detail for google that we can add in...
There was a problem hiding this comment.
@danielroe Resolved. Sorry for the delay!
|
Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielroe
Closes #34.
I didn't mean to create another subissue, GitHub didn't ask me for a confirmation when I clicked the "convert to issue" button..