Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: automatically add profile reporter when profile option enabled #94

Closed
wants to merge 1 commit into from
Closed

fix: automatically add profile reporter when profile option enabled #94

wants to merge 1 commit into from

Conversation

ilharp
Copy link
Contributor

@ilharp ilharp commented Nov 13, 2021 •
edited
Loading

#29 (comment)

Temporary workaround

With bars reporter:

new Webpackbar({
  reporters: ['fancy', 'profile'],
  profile: true,
}),

Without bars reporter:

new Webpackbar({
  reporters: ['profile'],
  profile: true,
}),

@ilharp
fix: fix unjs#29
f76e6e8 
unjs#29 (comment)

## Temporary workaround

```ts
new Webpackbar({
  reporters: ['fancy', 'profile'],
  profile: true,
}),
```
@pi0 pi0 changed the title fix: fix #29 fix: automatically add profile reporter when profile option enabled Dec 15, 2023
pi0
pi0 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pi0 added a commit that referenced this pull request Dec 15, 2023
@pi0 @ilharp
fix: automatically add profile reporter when profile option enabl…
762b65a 
…ed (#94)

Co-Authored-By: Il Harper <afanyiyu@hotmail.com>
@pi0
Copy link
Member

pi0 commented Dec 15, 2023

Manually merged via 762b65a

@pi0 pi0 closed this Dec 15, 2023
@gr00nd gr00nd mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilharp @pi0