Skip to content

Commit

Permalink
fix: inconsistent API spelling in docs and dashboard (#2275)
Browse files Browse the repository at this point in the history
* Fix incorrect error code for UNAUTHORIZED error

* fix : ratelimit sdk docs

* fix(docs): standardize spelling of "API" in dashboard and documentation
  • Loading branch information
Vardhaman619 authored Oct 8, 2024
1 parent 78ebf18 commit edbeb2d
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion apps/api/src/pkg/hono/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function newApp() {
app.doc("/openapi.json", {
openapi: "3.0.0",
info: {
title: "Unkey Api",
title: "Unkey API",
version: "1.0.0",
},

Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/app/(app)/apis/[apiId]/settings/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default async function SettingsPage(props: Props) {
<UpdateIpWhitelist api={api} workspace={workspace} />
<Card>
<CardHeader>
<CardTitle>Api ID</CardTitle>
<CardTitle>API ID</CardTitle>
<CardDescription>This is your api id. It's used in some API calls.</CardDescription>
</CardHeader>
<CardContent>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ export const UpdateApiName: React.FC<Props> = ({ api }) => {
<form onSubmit={form.handleSubmit(onSubmit)}>
<Card>
<CardHeader>
<CardTitle>Api Name</CardTitle>
<CardTitle>API Name</CardTitle>
<CardDescription>
Api names are not customer facing. Choose a name that makes it easy to recognize for
API names are not customer facing. Choose a name that makes it easy to recognize for
you.
</CardDescription>
</CardHeader>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export const ApiKeyTable: React.FC<Props> = ({ data }) => {
</DialogTrigger>
<DialogContent className="sm:max-w-[425px]">
<DialogHeader>
<DialogTitle>Revoke Api Key</DialogTitle>
<DialogTitle>Revoke API Key</DialogTitle>
<DialogDescription>
Delete the key <Badge variant="secondary">{row.original.start}...</Badge>{" "}
permanenty
Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/lib/trpc/routers/vercel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const vercelRouter = t.router({
});
});

// Api Id stuff
// API ID stuff

const setApiIdRes = await vercel.upsertEnvironmentVariable(
input.projectId,
Expand Down
4 changes: 2 additions & 2 deletions apps/docs/concepts/identities/ratelimits.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ In this case you would create an identity for the user and then create two ratel
Now if either one of those limits is exceeded, the request is denied.

<Info>
Api reference for verifying: [/api-reference/keys/verify](https://www.unkey.com/docs/api-reference/keys/verify)
API reference for verifying: [/api-reference/keys/verify](https://www.unkey.com/docs/api-reference/keys/verify)

Api reference for creating identities: [/api-reference/identities/create-identity](https://www.unkey.com/docs/api-reference/identities/create-identity)
API reference for creating identities: [/api-reference/identities/create-identity](https://www.unkey.com/docs/api-reference/identities/create-identity)
</Info>
8 changes: 4 additions & 4 deletions apps/docs/libraries/py/services/apis.mdx
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
---
title: "ApiService"
description: "The service used to make api related requests."
description: "The service used to make API related requests."
---

Available via the `apis` property of the `Client`.

See the [full docs](https://jonxslays.github.io/unkey.py/stable/reference/services/#unkey.services.ApiService)
on the `KeyService`.

## Get api
## Get API

Gets an api with the given ID.
Gets an API with the given ID.

```py
result = await client.apis.get_api("api_123")
```

## List keys

Retrieve a paginated list of api keys for a given api ID.
Retrieve a paginated list of API keys for a given API ID.

```py
# Page through keys 10 at a time
Expand Down

0 comments on commit edbeb2d

Please sign in to comment.