Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: write-a-blog-on-example-app-exp #2087

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

MichaelUnkey
Copy link
Collaborator

@MichaelUnkey MichaelUnkey commented Sep 12, 2024

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Introduced a blog post titled "Learn by building," detailing project management application development.
    • Added a procedure for fetching projects by category with input validation.
    • Implemented a form schema for controlled form elements.
    • Established rate limiting for secure routes in the application.
  • Documentation

    • Provided insights and strategies for effective TypeScript usage and debugging in the blog post.

Copy link

linear bot commented Sep 12, 2024

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:21pm
planetfall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:21pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:21pm
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:21pm
www ✅ Ready (Inspect) Visit Preview 18 resolved Sep 17, 2024 3:21pm

Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 28268a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 12, 2024

Walkthrough

Walkthrough

This pull request introduces a new blog post titled "Learn by building," which describes the author's experience in developing a web application for personal project management. It details the tools and technologies used, such as Auth.js, SQLite with Drizzle ORM, Next.js, and Unkey for rate limiting. Additionally, it includes new functionalities in the codebase, such as input validation with Zod, a rate-limited procedure in tRPC routes, and a controlled form schema.

Changes

File Path Change Summary
apps/www/content/blog/learn-by-building.mdx Added a blog post with metadata including date, title, image, description, author, and tags.
.../tRPC/routes Added getProjectsByCategory procedure with input validation using zod.
.../tRPC/routes Added formSchema for controlled form elements using zod and react-hook-form.
.../tRPC/routes Added rateLimitedProcedure for implementing rate limiting in tRPC routes.

Possibly related PRs

  • chore: added template to templates page #2074: The addition of the "unkey-trpc-ratelimit" template in the templates page is related to the main PR as it enhances the functionality of integrating tRPC with Unkey for rate limiting, which is a key topic discussed in the blog post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@MichaelUnkey MichaelUnkey marked this pull request as ready for review September 17, 2024 15:17
@MichaelUnkey MichaelUnkey added this pull request to the merge queue Sep 17, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
apps/www/content/blog/learn-by-building.mdx (1)

15-45: Informative overview of the project setup!

This section provides a clear overview of the tools, technologies, and approach used for building the project. Starting with the database schema is a good practice, and using the T3 stack for initial setup can boost productivity.

One minor suggestion:

  • The official spelling of the web framework is "Next.js" (with a dot).
Tools
LanguageTool

[uncategorized] ~30-~30: The official spelling of this programming framework is “Next.js”.
Context: ...- Auth.js - sqlite db and Drizzle ORM - NextJS - Unkey ratelimit protection I starte...

(NODE_JS)


[grammar] ~37-~37: The word “setup” is a noun. The verb is spelled with a space.
Context: ...myself a good starting point to quickly setup and hit the ground running. I found tha...

(NOUN_VERB_CONFUSION)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e2471b4 and 28268a6.

Files ignored due to path filters (2)
  • apps/www/public/images/blog-images/covers/learn-by-building.png is excluded by !**/*.png
  • apps/www/public/images/blog-images/learn-by-building/createt3.png is excluded by !**/*.png
Files selected for processing (1)
  • apps/www/content/blog/learn-by-building.mdx (1 hunks)
Additional context used
LanguageTool
apps/www/content/blog/learn-by-building.mdx

[uncategorized] ~30-~30: The official spelling of this programming framework is “Next.js”.
Context: ...- Auth.js - sqlite db and Drizzle ORM - NextJS - Unkey ratelimit protection I starte...

(NODE_JS)


[grammar] ~37-~37: The word “setup” is a noun. The verb is spelled with a space.
Context: ...myself a good starting point to quickly setup and hit the ground running. I found tha...

(NOUN_VERB_CONFUSION)


[grammar] ~52-~52: This is normally spelled as one word.
Context: ... about now. As usual, I was starting to over think the schema and layout and whatever else...

(OVER_COMPOUNDS)


[misspelling] ~55-~55: This word is normally spelled with a hyphen.
Context: ...erience as it allowed me to think about self restraint and management. Just telling myself tha...

(EN_COMPOUNDS_SELF_RESTRAINT)


[uncategorized] ~101-~101: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...s thing I need to worry about once setup so I can focus on the things that need to ...

(COMMA_COMPOUND_SENTENCE)


[grammar] ~112-~112: After ‘it’, use the third-person verb form “takes”.
Context: ...`` Unkey makes this incredible easy it take a couple of steps to implement. I used ...

(IT_VBZ)


[uncategorized] ~164-~164: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ke everyone else I hate bothering people but sometimes the best path forward to reac...

(COMMA_COMPOUND_SENTENCE_2)


[typographical] ~168-~168: It appears that a comma is missing.
Context: .... ## Conclusion In making this project I learned a hell of a lot. I now have a m...

(BY_FOR_IN_COMMA)


[typographical] ~168-~168: Consider adding a comma.
Context: ...ence, while docs will get you pretty far there is no substitute for another person to ...

(IF_THERE_COMMA)


[typographical] ~168-~168: Consider adding a comma here.
Context: ...ore features to this in the future, but for now I have added the example into Unkey's t...

(FOR_NOW_COMMA)

Additional comments not posted (4)
apps/www/content/blog/learn-by-building.mdx (4)

1-8: LGTM!

The blog post metadata follows the correct format and includes all necessary fields. The title, description, and tags are appropriate for the content. The image path is correct and the author field matches the post content.


64-80: Effective use of Zod for input validation!

The getProjectsByCategory procedure demonstrates a good use of Zod for input validation. The procedure correctly queries the database based on the provided category, limits the results to 50, and efficiently includes associated steps in the query.


85-99: Robust form validation using Zod!

The form schema defined using Zod provides robust validation rules for each field. The validation rules are appropriate and help prevent invalid data from being submitted. Making the image field optional provides flexibility, and restricting the image file types ensures only supported formats are allowed.


117-147: Well-implemented rate limiting for tRPC procedures!

The custom rateLimitedProcedure is a great addition to enforce rate limits on protected tRPC procedures. Using the Unkey Ratelimit library simplifies the implementation, and allowing the limit and duration to be configurable provides flexibility.

Throwing a specific TRPCError with a "TOO_MANY_REQUESTS" code helps clients handle rate limiting correctly, and adding the remaining rate limit information to the context is useful for monitoring and client-side handling.

Merged via the queue into main with commit 8c54eee Sep 17, 2024
26 checks passed
@MichaelUnkey MichaelUnkey deleted the eng-1323-write-a-blog-on-example-app-exp branch September 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants