Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: I Followed Unkey On X #2373

Closed

Conversation

yashkhokhar28
Copy link

@yashkhokhar28 yashkhokhar28 commented Oct 13, 2024

What does this PR do?

This PR provides proof of following Unkey on X by adding my name to the designated list file. It fulfills the requirement for completing the task. There are no dependencies or additional changes made in this PR.

Fixes # (No specific issue for this task, as it's a direct proof submission)

If there is not an issue for this, please create one first. This is used for tracking purposes and also helps us understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Proof of task completion (non-code update)

How should this be tested?

This can be tested by:

  • Verifying that my name has been added to the correct list file.
  • No additional tests are required for this change as it is a simple proof submission.
  • Here is a screenshot as proof of following Unkey on X:
Screenshot 2024-10-13 at 4 17 37 PM

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code (ensured name is added correctly)
  • Commented on my code in hard-to-understand areas (N/A for this task)
  • Ran pnpm build (N/A for this task)
  • Ran pnpm fmt (N/A for this task)
  • Checked for warnings, there are none
  • Removed all console.logs (N/A for this task)
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues (N/A for this task)

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR (N/A)
  • Updated the Unkey Docs if changes were necessary (N/A)

Summary by CodeRabbit

  • New Features

    • Added a new entry for user Yash Khokhar, including their X account handle and link.
  • Style

    • Minor formatting adjustments made for improved readability.

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: dde7962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 11:53am

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Oct 13, 2024

📝 Walkthrough

Walkthrough

The pull request updates the document oss.gg/3_follow_the_unkey_x_account.md by adding a new entry for user Yash Khokhar, who participated in the side quest. The entry includes the user's X account handle and a link to their account, dated 13-October-2024. Minor formatting adjustments were made, including the removal of an extra line before the new entry and the addition of a separator line after it.

Changes

File Path Change Summary
oss.gg/3_follow_the_unkey_x_account.md Added entry for Yash Khokhar with account link and date; minor formatting adjustments made.

Possibly related PRs

Suggested labels

🕹️ oss.gg, :joystick: 50 points

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 2028fe3 and d359d75.

📒 Files selected for processing (1)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

50-50: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
oss.gg/3_follow_the_unkey_x_account.md (1)

49-50: LGTM! The new entry is correctly formatted and placed.

The new entry for Yash Khokhar follows the specified format and is placed in the correct chronological order.

Regarding the static analysis hint about a bare URL: In this context, bare URLs are part of the required format for entries, so this can be safely ignored.

🧰 Tools
🪛 Markdownlint

50-50: null
Bare URL used

(MD034, no-bare-urls)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 13, 2024

@yashkhokhar28 is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Oct 13, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@yashkhokhar28 yashkhokhar28 changed the title followed x account of unkey feat: I Followed Unkey On X Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants