-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Five_friends_starred_repositories #2555
base: main
Are you sure you want to change the base?
Five_friends_starred_repositories #2555
Conversation
|
📝 WalkthroughWalkthroughA new section titled "Side Quest: 5 Friends Starred our Repositories" has been added to the document Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@DanishAliUmar is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
oss.gg/9_friends_starred_repositories.md (1)
5-5
: Fix redundant wording in points section.The word "Points" is repeated unnecessarily.
-Points: 150 Points +## Reward + +**150 Points**
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/9_friends_starred_repositories.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
oss.gg/9_friends_starred_repositories.md
[style] ~7-~7: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 477 characters long)
Context: ... our repos Points: 150 Points Proof: ![github5](https://github.com/user-attach...(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (1)
oss.gg/9_friends_starred_repositories.md (1)
8-12
: Verify image attachments are accessible.Let's ensure all image attachments are properly uploaded and accessible.
✅ Verification successful
Image attachments are accessible
All image attachments return HTTP 302 status codes, which indicates they are valid GitHub asset URLs that redirect to the actual image content. This is the expected behavior for GitHub's user-attachments system.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if image attachments are accessible # Test: Verify HTTP status codes for each attachment URL for asset_id in \ "67a7bb21-dc4a-4683-9918-8ed6dbdc9af1" \ "92a298ce-3b09-42df-973f-e1537e153b08" \ "16545c5e-5a67-4987-82ec-5a3430a2f2d8" \ "9f14366b-5b8c-4916-b31a-0b2b6e3c77fe" \ "b0f7bb00-e74d-4a35-acdb-917d0ed5afd2" do echo "Checking asset: $asset_id" curl -s -o /dev/null -w "%{http_code}" "https://github.com/user-attachments/assets/$asset_id" doneLength of output: 2259
Side Quest:5 Friends Starred our Repositories | ||
|
||
Get 5 friends to star our repos | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve markdown formatting and add detailed instructions.
The title and description need proper formatting and more detailed instructions.
Apply these changes:
-Side Quest:5 Friends Starred our Repositories
+# Side Quest: 5 Friends Starred our Repositories
-Get 5 friends to star our repos
+## Instructions
+
+Get 5 friends to star our repositories. To complete this quest:
+
+1. Ask your friends to star the following repositories: [list repositories]
+2. Take screenshots of the star notifications or repository pages showing the stars
+3. Submit the screenshots as proof of completion
Committable suggestion was skipped due to low confidence.
Proof: | ||
![github2](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1) | ||
![github3](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08) | ||
![github4](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8) | ||
![github5](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe) | ||
![github](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance image documentation and accessibility.
The images need better naming and accessibility improvements:
- Use descriptive names instead of sequential numbers
- Add meaningful alt text describing each screenshot
- Include a brief description of what each image represents
Proof:
-![github2](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
-![github3](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
-![github4](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
-![github5](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
-![github](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
+## Proof of Completion
+
+### Friend 1's Star
+![Screenshot showing repository starred by friend 1](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
+
+### Friend 2's Star
+![Screenshot showing repository starred by friend 2](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
+
+### Friend 3's Star
+![Screenshot showing repository starred by friend 3](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
+
+### Friend 4's Star
+![Screenshot showing repository starred by friend 4](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
+
+### Friend 5's Star
+![Screenshot showing repository starred by friend 5](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Proof: | |
![github2](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1) | |
![github3](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08) | |
![github4](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8) | |
![github5](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe) | |
![github](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2) | |
Proof: | |
## Proof of Completion | |
### Friend 1's Star | |
![Screenshot showing repository starred by friend 1](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1) | |
### Friend 2's Star | |
![Screenshot showing repository starred by friend 2](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08) | |
### Friend 3's Star | |
![Screenshot showing repository starred by friend 3](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8) | |
### Friend 4's Star | |
![Screenshot showing repository starred by friend 4](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe) | |
### Friend 5's Star | |
![Screenshot showing repository starred by friend 5](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2) |
🧰 Tools
🪛 LanguageTool
[style] ~7-~7: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 477 characters long)
Context: ... our repos Points: 150 Points Proof: ![github5](https://github.com/user-attach...(EN_EXCESSIVE_EXCLAMATION)
please post the screenshots proving that you asked them and link their github accounts here |
What does this PR do?
This involves getting 5 friends to star the repositories participating in the oss.gg hackathon and submitting screenshots as proof in each repository's issues.
Fixes # (issue)
🌟 Starry-eyed Supporter
Type of change
How should this be tested?
Checklist
Required
pnpm build
pnpm fmt
console.logs
git pull origin main
Appreciated