Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Five_friends_starred_repositories #2555

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DanishAliUmar
Copy link

@DanishAliUmar DanishAliUmar commented Oct 24, 2024

What does this PR do?

This involves getting 5 friends to star the repositories participating in the oss.gg hackathon and submitting screenshots as proof in each repository's issues.

Fixes # (issue)

🌟 Starry-eyed Supporter

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: f083250

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

📝 Walkthrough

Walkthrough

A new section titled "Side Quest: 5 Friends Starred our Repositories" has been added to the document oss.gg/9_friends_starred_repositories.md. This section describes a task for users to encourage five friends to star their repositories, offering a reward of 150 points. It also includes five images linked to GitHub as proof of completion.

Changes

File Path Change Summary
oss.gg/9_friends_starred_repositories.md Added a new section for a task involving friends starring repositories, including a reward of 150 points and proof images.

Possibly related PRs

  • Chore/add line to oss gg file #2456: The PR adds a new entry under a "Side Quest" section that requires participants to get five friends to star the repository, which is directly related to the new section added in the main PR.

Suggested labels

Needs Approval, 🕹️ oss.gg, :joystick: 150 points

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:24am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

vercel bot commented Oct 24, 2024

@DanishAliUmar is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "Five_friends_starred_repositories". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)
oss.gg/9_friends_starred_repositories.md (1)

5-5: Fix redundant wording in points section.

The word "Points" is repeated unnecessarily.

-Points: 150 Points
+## Reward
+
+**150 Points**
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 83ed260 and f083250.

📒 Files selected for processing (1)
  • oss.gg/9_friends_starred_repositories.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
oss.gg/9_friends_starred_repositories.md

[style] ~7-~7: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 477 characters long)
Context: ... our repos Points: 150 Points Proof: github2 github3 github4 ![github5](https://github.com/user-attach...

(EN_EXCESSIVE_EXCLAMATION)

🔇 Additional comments (1)
oss.gg/9_friends_starred_repositories.md (1)

8-12: Verify image attachments are accessible.

Let's ensure all image attachments are properly uploaded and accessible.

✅ Verification successful

Image attachments are accessible

All image attachments return HTTP 302 status codes, which indicates they are valid GitHub asset URLs that redirect to the actual image content. This is the expected behavior for GitHub's user-attachments system.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if image attachments are accessible
# Test: Verify HTTP status codes for each attachment URL

for asset_id in \
  "67a7bb21-dc4a-4683-9918-8ed6dbdc9af1" \
  "92a298ce-3b09-42df-973f-e1537e153b08" \
  "16545c5e-5a67-4987-82ec-5a3430a2f2d8" \
  "9f14366b-5b8c-4916-b31a-0b2b6e3c77fe" \
  "b0f7bb00-e74d-4a35-acdb-917d0ed5afd2"
do
  echo "Checking asset: $asset_id"
  curl -s -o /dev/null -w "%{http_code}" "https://github.com/user-attachments/assets/$asset_id"
done

Length of output: 2259

Comment on lines +1 to +4
Side Quest:5 Friends Starred our Repositories

Get 5 friends to star our repos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Improve markdown formatting and add detailed instructions.

The title and description need proper formatting and more detailed instructions.

Apply these changes:

-Side Quest:5 Friends Starred our Repositories
+# Side Quest: 5 Friends Starred our Repositories
 
-Get 5 friends to star our repos
+## Instructions
+
+Get 5 friends to star our repositories. To complete this quest:
+
+1. Ask your friends to star the following repositories: [list repositories]
+2. Take screenshots of the star notifications or repository pages showing the stars
+3. Submit the screenshots as proof of completion

Committable suggestion was skipped due to low confidence.

Comment on lines +7 to +12
Proof:
![github2](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
![github3](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
![github4](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
![github5](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
![github](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Enhance image documentation and accessibility.

The images need better naming and accessibility improvements:

  1. Use descriptive names instead of sequential numbers
  2. Add meaningful alt text describing each screenshot
  3. Include a brief description of what each image represents
 Proof: 
-![github2](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
-![github3](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
-![github4](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
-![github5](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
-![github](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
+## Proof of Completion
+
+### Friend 1's Star
+![Screenshot showing repository starred by friend 1](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
+
+### Friend 2's Star
+![Screenshot showing repository starred by friend 2](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
+
+### Friend 3's Star
+![Screenshot showing repository starred by friend 3](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
+
+### Friend 4's Star
+![Screenshot showing repository starred by friend 4](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
+
+### Friend 5's Star
+![Screenshot showing repository starred by friend 5](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Proof:
![github2](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
![github3](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
![github4](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
![github5](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
![github](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
Proof:
## Proof of Completion
### Friend 1's Star
![Screenshot showing repository starred by friend 1](https://github.com/user-attachments/assets/67a7bb21-dc4a-4683-9918-8ed6dbdc9af1)
### Friend 2's Star
![Screenshot showing repository starred by friend 2](https://github.com/user-attachments/assets/92a298ce-3b09-42df-973f-e1537e153b08)
### Friend 3's Star
![Screenshot showing repository starred by friend 3](https://github.com/user-attachments/assets/16545c5e-5a67-4987-82ec-5a3430a2f2d8)
### Friend 4's Star
![Screenshot showing repository starred by friend 4](https://github.com/user-attachments/assets/9f14366b-5b8c-4916-b31a-0b2b6e3c77fe)
### Friend 5's Star
![Screenshot showing repository starred by friend 5](https://github.com/user-attachments/assets/b0f7bb00-e74d-4a35-acdb-917d0ed5afd2)
🧰 Tools
🪛 LanguageTool

[style] ~7-~7: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 477 characters long)
Context: ... our repos Points: 150 Points Proof: github2 github3 github4 ![github5](https://github.com/user-attach...

(EN_EXCESSIVE_EXCLAMATION)

@chronark
Copy link
Collaborator

please post the screenshots proving that you asked them and link their github accounts here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants