Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 sidequest #2617

Closed
wants to merge 4 commits into from
Closed

2 sidequest #2617

wants to merge 4 commits into from

Conversation

AshishViradiya153
Copy link

@AshishViradiya153 AshishViradiya153 commented Oct 30, 2024 •
edited by coderabbitai bot
Loading

What does this PR do?

Fixes #2150

2 sidequest
1: follow on x,
2: Article and repo link

Protecting Your API with Unkey: Implementing Rate Limiting for openAI Meme Generation

Article: https://medium.com/@ashishviradiya153/protecting-your-api-with-unkey-implementing-rate-limiting-for-ai-meme-generation-1bfb2c681368
Github: https://github.com/AshishViradiya153/AI-meme-genereter

Summary by CodeRabbit

  • New Features

    • Added a new entry for user contributions under "Follow the Unkey X account."
    • Updated template creation guidelines for Unkey integration with various frameworks.
    • Introduced a new blog post discussing API protection and rate limiting using Unkey.

  • Bug Fixes

    • Corrected spelling error in the contributions list.

  • Documentation

    • Enhanced clarity and accuracy in documentation for template submissions and blog entries.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0a8c44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:05pm

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024

@AshishViradiya153 is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024 •
edited
Loading

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request includes updates to three documents related to the Unkey project. The first document adds a new entry for a user under the "Follow the Unkey X account" section. The second document revises the template creation guidelines, emphasizing the need for a minimal starter template and listing new contributions. The third document introduces a new blog post entry discussing API protection with Unkey. Each update maintains the established formatting and structure.

Changes

File Path Change Summary
oss.gg/3_follow_the_unkey_x_account.md Added a new entry for Zia Ur Rehman, including submission date, username, and account link.
oss.gg/7_create_a_template.md Updated template creation guidelines, added new contributions, and corrected a spelling error.
oss.gg/8_use_unkey_blog.md Added a new blog post entry by Ashish Viradiya discussing API protection and rate limiting.

Possibly related PRs

Suggested labels

🕹️ oss.gg, :joystick: 50 points, :joystick: 1500 points, hacktoberfest

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Here is an example:

<type>[optional scope]: <description>
fix: I fixed something for Unkey

Details:

No release type found in pull request title "2 sidequest". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

coderabbitai[bot]
coderabbitai bot reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
oss.gg/7_create_a_template.md (1)

40-40: Fix link formatting.

Remove the extra spaces inside the link text to comply with Markdown formatting standards.

Apply this fix:

-[Starter template for Unkey Route protecttion in Hono Webframework in Cloudflare workers ](https://github.com/prabincankod/hono-unkey-cflare)
+[Starter template for Unkey Route protecttion in Hono Webframework in Cloudflare workers](https://github.com/prabincankod/hono-unkey-cflare)

Also applies to: 47-47

🧰 Tools
🪛 Markdownlint

40-40: null
Spaces inside link text

(MD039, no-space-in-links)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7c76890 and a7958ae.

📒 Files selected for processing (3)
  • oss.gg/3_follow_the_unkey_x_account.md (1 hunks)
  • oss.gg/7_create_a_template.md (2 hunks)
  • oss.gg/8_use_unkey_blog.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • oss.gg/8_use_unkey_blog.md
🧰 Additional context used
🪛 Markdownlint
oss.gg/3_follow_the_unkey_x_account.md

59-59: null
Bare URL used

(MD034, no-bare-urls)

oss.gg/7_create_a_template.md

40-40: null
Spaces inside link text

(MD039, no-space-in-links)

47-47: null
Spaces inside link text

(MD039, no-space-in-links)

🔇 Additional comments (1)
oss.gg/7_create_a_template.md (1)

59-60: Verify template requirements.

The new submission for the GPT + Unkey Ratelimit Starter should be verified against the requirements:

  • MIT license
  • README.md with quickstart guide
  • No duplicate with existing templates at unkey.com/templates

Let's verify these requirements:

oss.gg/7_create_a_template.md Show resolved Hide resolved
@unkeyed unkeyed deleted a comment from AshishViradiya153 Nov 1, 2024
@chronark chronark closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr is a code owner

@chronark chronark Awaiting requested review from chronark chronark is a code owner

@mcstepp mcstepp Awaiting requested review from mcstepp mcstepp is a code owner

@MichaelUnkey MichaelUnkey Awaiting requested review from MichaelUnkey MichaelUnkey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🕹️] SIDE QUESTS: https://go.unkey.com/ossgg-challenges
3 participants
@AshishViradiya153 @CLAassistant @chronark