-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade next to 14.latest #2772
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
📝 WalkthroughWalkthroughThis pull request involves updating the Next.js dependency version to Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (4)
🔇 Additional comments (2)packages/nextjs/package.json (1)
The Next.js version update to apps/engineering/package.json (1)
The change from Let's check for potential Next.js 15 specific features: Consider:
✅ Verification successfulLet me gather more information about the Next.js usage, particularly focusing on the config and any experimental features. ✅ Next.js downgrade appears safe to proceed The codebase inspection shows:
The only mention of "turbo" is in an RFC markdown file, not in the actual configuration or code. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Search for Next.js 15 specific features in the engineering app
# Focus on common Next.js patterns and config files
# Check for Next.js config
echo "Checking Next.js config..."
rg -l "next.config" apps/engineering/
# Check for potential Next.js 15 specific imports or features
echo "Checking for Next.js specific patterns..."
rg -l "use server" apps/engineering/
rg -l "use client" apps/engineering/
rg -l "experimental:" apps/engineering/
# Check package-lock.json for any remaining v15 dependencies
echo "Checking for other Next.js 15 dependencies..."
rg "next@15" package-lock.json || true
Length of output: 1036 Script: #!/bin/bash
# Let's examine the Next.js configuration and component usage more closely
# Check the content of next.config.js if it exists
echo "Checking Next.js config content..."
fd "next.config" apps/engineering/ --exec cat {}
# Look for specific Next.js 15 features and APIs
echo "Checking for specific Next.js patterns..."
rg "appDir|serverActions|instrumentationHook|turbo|optimizePackageImports" apps/engineering/
# Check for usage of newer Next.js APIs
echo "Checking for Next.js API usage..."
rg "unstable_|experimental" apps/engineering/
# Check for server components pattern
echo "Checking for server components..."
rg "async function|export async function" apps/engineering/app/ -l
Length of output: 1118 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested the dashboard seems fine to me as did the site.
Did we want to downgrade engineering to 14X from 15X?
yeah that was intentional, I’d rather have it unified, cause in the past I had some issues with mixed versions in monorepos |
Cool approved |
Summary by CodeRabbit
New Features
Bug Fixes
Chores