Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade next to 14.latest #2772

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: upgrade next to 14.latest #2772

merged 1 commit into from
Dec 20, 2024

Conversation

chronark
Copy link
Collaborator

@chronark chronark commented Dec 20, 2024

Summary by CodeRabbit

  • New Features

    • Upgraded the Next.js framework across multiple projects, enhancing performance and potentially introducing new features.
  • Bug Fixes

    • Addressed issues related to the previous versions of the Next.js dependency by updating to a more stable version.
  • Chores

    • Updated dependency versions in various package configurations without altering other components.

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:13pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:13pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:13pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:13pm

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 3e76cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

📝 Walkthrough

Walkthrough

This pull request involves updating the Next.js dependency version to 14.2.15 across multiple packages and applications within the project. The changes are consistent across different package.json files, including dashboard, engineering, play, www, cache, and nextjs packages. The update appears to be a uniform version bump from previous versions (mostly 14.2.10) to the new 14.2.15 version, potentially addressing bug fixes or improvements in the Next.js framework.

Changes

File Change Summary
apps/dashboard/package.json Updated Next.js from 14.2.10 to 14.2.15
apps/engineering/package.json Updated Next.js from ^15.0.3 to 14.2.15
apps/play/package.json Updated Next.js from 14.2.10 to 14.2.15
apps/www/package.json Updated Next.js from 14.2.10 to 14.2.15
packages/cache/package.json Updated Next.js from ^14.2.10 to 14.2.15
packages/nextjs/package.json Updated Next.js from ^14.2.10 to 14.2.15

Possibly related PRs

Suggested reviewers

  • mcstepp
  • perkinsjr
  • MichaelUnkey

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e886e0d and 3e76cfc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • apps/dashboard/package.json (1 hunks)
  • apps/engineering/package.json (1 hunks)
  • apps/play/package.json (1 hunks)
  • apps/www/package.json (1 hunks)
  • packages/cache/package.json (1 hunks)
  • packages/nextjs/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • apps/www/package.json
  • apps/play/package.json
  • packages/cache/package.json
  • apps/dashboard/package.json
🔇 Additional comments (2)
packages/nextjs/package.json (1)

23-23: LGTM! Version pinning improvement.

The Next.js version update to 14.2.15 with removal of the caret (^) is a good practice for a public package, ensuring consistent behavior across installations.

apps/engineering/package.json (1)

23-23: ⚠️ Verify compatibility after Next.js major version downgrade

The change from ^15.0.3 to 14.2.15 is a major version downgrade. This requires careful verification to ensure no Next.js 15 specific features are being used in the engineering app.

Let's check for potential Next.js 15 specific features:

Consider:

  1. Testing the engineering app thoroughly after this downgrade
  2. Documenting any required code changes in the PR description
  3. Updating deployment configurations if necessary
✅ Verification successful

Let me gather more information about the Next.js usage, particularly focusing on the config and any experimental features.


✅ Next.js downgrade appears safe to proceed

The codebase inspection shows:

  • Simple Next.js configuration without experimental features
  • Standard usage of client/server components compatible with Next.js 14
  • No usage of Next.js 15 specific APIs or experimental features
  • Basic async server components that are supported in Next.js 14

The only mention of "turbo" is in an RFC markdown file, not in the actual configuration or code.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for Next.js 15 specific features in the engineering app
# Focus on common Next.js patterns and config files

# Check for Next.js config
echo "Checking Next.js config..."
rg -l "next.config" apps/engineering/

# Check for potential Next.js 15 specific imports or features
echo "Checking for Next.js specific patterns..."
rg -l "use server" apps/engineering/
rg -l "use client" apps/engineering/
rg -l "experimental:" apps/engineering/

# Check package-lock.json for any remaining v15 dependencies
echo "Checking for other Next.js 15 dependencies..."
rg "next@15" package-lock.json || true

Length of output: 1036


Script:

#!/bin/bash
# Let's examine the Next.js configuration and component usage more closely

# Check the content of next.config.js if it exists
echo "Checking Next.js config content..."
fd "next.config" apps/engineering/ --exec cat {}

# Look for specific Next.js 15 features and APIs
echo "Checking for specific Next.js patterns..."
rg "appDir|serverActions|instrumentationHook|turbo|optimizePackageImports" apps/engineering/

# Check for usage of newer Next.js APIs
echo "Checking for Next.js API usage..."
rg "unstable_|experimental" apps/engineering/

# Check for server components pattern
echo "Checking for server components..."
rg "async function|export async function" apps/engineering/app/ -l

Length of output: 1118


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Collaborator

@perkinsjr perkinsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested the dashboard seems fine to me as did the site.

Did we want to downgrade engineering to 14X from 15X?

Copy link
Collaborator Author

yeah that was intentional, I’d rather have it unified, cause in the past I had some issues with mixed versions in monorepos

Copy link
Collaborator

Cool approved

@chronark chronark added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 3a74bb8 Dec 20, 2024
28 checks passed
@chronark chronark deleted the nextjs-14-2-15 branch December 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants