Small touch-up for scripts in general #11
Conversation
|
|
||
| func _pressed(): | ||
| var _stfu = get_tree().change_scene_to(scene) |
There was a problem hiding this comment.
The _ is used to suppress the "unused variable" warnings in 3.1 compared to var stfu.
(Without the var _stfu = part entirely, Godot 3.1 gives warnings about an unused return value from change_scene_to)
There was a problem hiding this comment.
Are we even gonna use this variable for anything? Because this method can be called directly.
There was a problem hiding this comment.
Godot 3.1 gives warnings about an unused return value from change_scene_to
There was a problem hiding this comment.
Then #warning-ignore:return_value_discarded should be used. Makes more sense than creating a variable just to silence the warning.
There was a problem hiding this comment.
And with that, another thing that somehow I didn't noticed before: Why each button has its own script? The menu scene should have a script that holds all of these methods.
There was a problem hiding this comment.
#warning-ignore:return_value_discarded is longer to write than var _stfu = and does the same thing.
Having a "Button Manager" script would go against object-oriented design, but could be done I think. I'd suggest asking @LinuxDonald what his preferred programming paradigm is. I don't know if there's a standard in Godot for managers vs self-managed, but I do know that in Godot each node is supposed to only perform one function.
There was a problem hiding this comment.
#warning-ignore:return_value_discarded is longer to write than var _stfu = and does the same thing.
That's still creating a variable just to silence a warning! Besides being far more explicit, if there's a system to properly ignore warnings, that should be used instead of this.
I'd suggest asking @LinuxDonald what his preferred programming paradigm is.
Considering that he's just starting to learn Godot as far as I'm aware, I don't think that would help that much, but I could give it a shot.
However, most projects that I've seen (including official ones: 1, 2) just connect the buttons to the main script, as it's much more manageable than hopping through scripts for such small tasks.
preloadinstead ofload.passes.