Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywall does not launch on Brave #1154

Closed
cnasc opened this issue Jan 22, 2019 · 9 comments
Closed

Paywall does not launch on Brave #1154

cnasc opened this issue Jan 22, 2019 · 9 comments
Assignees
Labels
frontend architecture and design->code for the unlock app frontend
Milestone

Comments

@cnasc
Copy link
Contributor

cnasc commented Jan 22, 2019

Describe the bug
Paywall does not render when using Brave browser.

To Reproduce
Steps to reproduce the behavior:

  1. Use Brave browser with Metamask installed and logged in.
  2. Go to a page that has a lock that you do not have a key for.
  3. Note that no paywall appears.

Expected behavior
A paywall will appear that prevents me from scrolling/using the page and provides the opportunity to purchase a key that will grant me access.

Desktop (please complete the following information):

  • OS: macOS 10.13.6
  • Browser Brave 0.58.21

Additional context
Error console:
screen shot 2019-01-22 at 12 38 54 pm

The app dies when localStorage access fails. @cellog pointed out that there is no use of localStorage in the unlock-app codebase and that it may be something in node_modules trying to use it.

@nfurfaro
Copy link
Contributor

@cnasc I think this is working for me. Will update, but currently at 7 confirmations.
image

@nfurfaro
Copy link
Contributor

So, this works for me on Rinkeby on a lock I created. I don't see a paywall on Sascha's page...

@cnasc cnasc added p-1 frontend architecture and design->code for the unlock app frontend labels Jan 22, 2019
@julien51
Copy link
Member

Moving to p2 as this is maybe not as critical now that Brave is not special anymore? (no web3 provider in in by default)

@julien51 julien51 added p-2 and removed p-1 labels Jan 22, 2019
@julien51 julien51 added this to the Version 0 milestone Jan 27, 2019
@akeem
Copy link
Contributor

akeem commented Jan 28, 2019

This appears to be related to a chromium security setting, https://www.chromium.org/for-testers/bug-reporting-guidelines/uncaught-securityerror-failed-to-read-the-localstorage-property-from-window-access-is-denied-for-this-document . With this noted, i'll see how this can be resolved

@akeem akeem self-assigned this Jan 28, 2019
@akeem
Copy link
Contributor

akeem commented Jan 29, 2019

web3/web3.js#2203 should resolve this issue, there will be an increase in scope as we will need to accommodate for additional changes introduced to web3

@akeem
Copy link
Contributor

akeem commented Jan 30, 2019

At the moment, this is consider blocked until we can upgrade unlock-app to 1.0.0.beta41

@akeem akeem added the BLOCKED label Jan 30, 2019
@akeem
Copy link
Contributor

akeem commented Feb 7, 2019

This is still pending an upgrade to a recent version of web3. It should be picked up after the work I currently have in play

@julien51
Copy link
Member

julien51 commented Mar 1, 2019

We're waiting for a new deploy to production to check this but it should be fixed.

@cellog
Copy link
Contributor

cellog commented Mar 27, 2019

this is fixed on the desktop version of brave, broken on mobile (#2366)

@cellog cellog closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend architecture and design->code for the unlock app frontend
Projects
None yet
Development

No branches or pull requests

5 participants