-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paywall does not launch on Brave #1154
Comments
@cnasc I think this is working for me. Will update, but currently at 7 confirmations. |
So, this works for me on Rinkeby on a lock I created. I don't see a paywall on Sascha's page... |
Moving to p2 as this is maybe not as critical now that Brave is not special anymore? (no web3 provider in in by default) |
This appears to be related to a chromium security setting, https://www.chromium.org/for-testers/bug-reporting-guidelines/uncaught-securityerror-failed-to-read-the-localstorage-property-from-window-access-is-denied-for-this-document . With this noted, i'll see how this can be resolved |
web3/web3.js#2203 should resolve this issue, there will be an increase in scope as we will need to accommodate for additional changes introduced to web3 |
At the moment, this is consider blocked until we can upgrade unlock-app to 1.0.0.beta41 |
This is still pending an upgrade to a recent version of web3. It should be picked up after the work I currently have in play |
We're waiting for a new deploy to production to check this but it should be fixed. |
this is fixed on the desktop version of brave, broken on mobile (#2366) |
Describe the bug
Paywall does not render when using Brave browser.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A paywall will appear that prevents me from scrolling/using the page and provides the opportunity to purchase a key that will grant me access.
Desktop (please complete the following information):
Additional context
Error console:
The app dies when localStorage access fails. @cellog pointed out that there is no use of localStorage in the unlock-app codebase and that it may be something in node_modules trying to use it.
The text was updated successfully, but these errors were encountered: