Fix - allow web3 to work in iframes with third party cookies turned off #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
approved these changes
Jan 21, 2019
joshstevens19
deleted the
fix/allow-web3-to-work-in-iframes-with-3rd-party-cookies-turned-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if you iframe in a website which uses web3 and has third party cookies turned off (safari by default has this) web3 lib throws security generic exceptions. This is due to trying to access the
localStoragecontext when third party cookies are off.I have now allowed web3 to run as it would if third party cookies are on minus saving stuff to local storage. It will just allow the code to just work and mask the security error. I have made it so it looks for the security code so it wont affect general errors being throw for the developer.
We should be supporting web3 to work in any zone especially in iframes as we discussed on telegram.
Thanks
Josh