Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(unlock-app): simplified our use of localStorage #15288

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

julien51
Copy link
Member

Description

No change in logic, just some cleanup and refactor to make sure we only use localStorage consistently!

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@julien51 julien51 requested a review from 0xTxbi December 23, 2024 10:52
@cla-bot cla-bot bot added the cla-signed label Dec 23, 2024
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unlock-static-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 10:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unlock-storybook ⬜️ Ignored (Inspect) Dec 23, 2024 10:58am


export function useAppStorage() {
// Get and set items in local storage, with caching!
const getStorage = useCallback(getLocalStorageItem, [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@julien51 julien51 merged commit 34ca5e8 into master Dec 24, 2024
16 checks passed
@julien51 julien51 deleted the localstorage-refactor branch December 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants