Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rollup in both unlock-app and paywall #1984

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

cellog
Copy link
Contributor

@cellog cellog commented Mar 10, 2019

Description

This PR upgrades rollup, and its plugins. It also swaps out rollup-plugin-uglify for rollup-plugin-terser because of webpack-contrib/terser-webpack-plugin#15 (and similar discussions in many other projects, and lots of buzz on twitter discussing similar improvements with terser vs. uglify.

Issues

Fixes #1675

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
    • This PR only contains configuration changes (package.json, etc.)
    • This PR only contains code changes (if configuration changes are required, do a separate PR first, then re-base)
  • My code follows the style guidelines of this project, including naming conventions
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • If my code adds or changes components, I have written corresponding stories with Storybook
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@cellog cellog self-assigned this Mar 10, 2019
@cellog cellog requested review from julien51 and cnasc March 10, 2019 03:41
@cellog cellog force-pushed the greg-1675-rollup branch from 2c81d79 to 0e379e0 Compare March 10, 2019 13:59
@cellog cellog force-pushed the greg-1675-rollup branch from 0e379e0 to 79e3989 Compare March 10, 2019 17:37
Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Greg!

@cellog cellog merged commit bd2e612 into master Mar 11, 2019
@cellog cellog deleted the greg-1675-rollup branch March 11, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An in-range update of rollup is breaking the build 🚨
2 participants