Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan mods don't work #19

Closed
1 task done
I-like-stuff opened this issue Jul 5, 2024 · 3 comments · Fixed by #22
Closed
1 task done

vulkan mods don't work #19

I-like-stuff opened this issue Jul 5, 2024 · 3 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@I-like-stuff
Copy link

Operating System

Linux

Version of Fjord Launcher

Fjord Launcher 8.4

Version of Qt

Qt 6.7.2

Description of bug

if I run a different instance with the vulkanmod installed, I get this
image

there was a way to tackle this in prismlauncher and the now dead pollymc which was to add "additional libs" and then insert "vulkan-loader" to fix the problem in Nixos however that doesn't seem to work here in fjord so I'm not sure

Steps to reproduce

install vulkanmod on any instance and you'll likely going to run in the same issue

Suspected cause

vulkan-loader isn't included as a dependency over in the fjord launcher nix package which is preventing me from adding it as an additional library

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@I-like-stuff I-like-stuff added the bug Something isn't working label Jul 5, 2024
@i-can-not-program
Copy link
Contributor

there was a way to tackle this in prismlauncher and the now dead pollymc which was to add "additional libs" and then insert "vulkan-loader" to fix the problem in Nixos however that doesn't seem to work here in fjord so I'm not sure

It works for me with this:

fjordlauncher.override { additionalLibs = [ vulkan-loader ]; }

I don't think this should be added by default, since it is not required by the vanilla game and additional libraries can easily be added.

@evan-goode
Copy link
Member

The prismlauncher derivation in nixpkgs has vulkan-loader as of NixOS/nixpkgs#303880, but the derivation in Prism's upstream repository (and therefore Fjord's) doesn't. I'm happy to cherry-pick this in for now, and I'll ask upstream about keeping their derivation in sync with nixpkgs.

@evan-goode
Copy link
Member

I filed PrismLauncher/PrismLauncher#2667, let's wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants