prismlauncher: add vulkan-loader #303880
Merged
prismlauncher: add vulkan-loader #303880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
|
Result of 2 packages built:
|
ofborg
bot
added
10.rebuild-darwin: 0
|
Shouldn't this change also be added to the -unwrapped package? Sorry if I am a bit noobish |
no, as prism doesn't need vulkan-loader at build time. for runtime dependencies like these, we use the wrapper |
getchoo
approved these changes
Apr 14, 2024
getchoo
added
12.approvals: 1
1 task
evan-goode
added a commit
to unmojang/PrismLauncher
that referenced
this pull request
Jul 20, 2024
Brings in changes from the Prism Launcher derivation(s) in nixpkgs, notably from NixOS/nixpkgs#321851 and NixOS/nixpkgs#303880 Signed-off-by: Evan Goode <mail@evangoo.de>
evan-goode
added a commit
to unmojang/PrismLauncher
that referenced
this pull request
Jul 21, 2024
Brings in changes from the Prism Launcher derivation(s) in nixpkgs, notably from NixOS/nixpkgs#321851 and NixOS/nixpkgs#303880 Signed-off-by: Evan Goode <mail@evangoo.de>
evan-goode
added a commit
to unmojang/FjordLauncher
that referenced
this pull request
Aug 12, 2024
Brings in changes from the Prism Launcher derivation(s) in nixpkgs, notably from NixOS/nixpkgs#321851 and NixOS/nixpkgs#303880 Signed-off-by: Evan Goode <mail@evangoo.de>
evan-goode
added a commit
to unmojang/FjordLauncher
that referenced
this pull request
Aug 12, 2024
Brings in changes from the Prism Launcher derivation(s) in nixpkgs, notably from NixOS/nixpkgs#321851 and NixOS/nixpkgs#303880 Signed-off-by: Evan Goode <mail@evangoo.de>
dingdang66686
added a commit
to dingdang66686/nixpkgs
that referenced
this pull request
Jan 11, 2025
referring to NixOS#303880 to support VulkanMod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #303765
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.