Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various source layout & architecture improvements #26

Open
6 tasks done
pbrkr opened this issue May 8, 2023 · 0 comments
Open
6 tasks done

Various source layout & architecture improvements #26

pbrkr opened this issue May 8, 2023 · 0 comments
Milestone
mirrorshades v0.3.0

Comments

@pbrkr
Copy link
Collaborator

pbrkr commented May 8, 2023 •
edited
Loading

  • Looking at Support attr directive with static evaluation pypa/setuptools#1753, we should still be able to read __version__ from __init__.py in setuptools even if __init__.py imports libraries which haven't yet been installed. Test this and if all is good then simplify the source organisation accordingly.
  • Move main() and parse_args() to the __main__.py module.
  • Drop global variables from config.py, instead pass the relevant objects around as needed.
  • Merge config.py into __init__.py.
  • Add a dev-requirements.txt file to simplify development envrionment setup.
  • Standardise command execution and improve logging.
@pbrkr pbrkr added this to the v0.3.0 milestone May 8, 2023
pbrkr added a commit that referenced this issue May 8, 2023
@pbrkr
Simplify installation of dev dependencies
f68bc98 
Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
@pbrkr pbrkr moved this to In Progress in The Plan May 8, 2023
@pbrkr pbrkr added this to The Plan May 8, 2023
pbrkr added a commit that referenced this issue May 8, 2023
@pbrkr
Simplify installation of dev dependencies
80beae9 
Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
pbrkr added a commit that referenced this issue May 8, 2023
@pbrkr
Refactor main function
d974826 
Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
pbrkr added a commit that referenced this issue May 8, 2023
@pbrkr
Refactor main function
5d2a1b4 
Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
pbrkr added a commit that referenced this issue May 8, 2023
@pbrkr
Refactor main function
14b046d 
Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
pbrkr added a commit that referenced this issue May 8, 2023
@pbrkr
Refactor configuration
117b90d 
* Drop the separate 'config' module and global state.
* Define a new 'Configuration' class to manage state sensibly.
* Improve exception handling.

Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
pbrkr added a commit that referenced this issue Jun 11, 2023
@pbrkr
Standardise command invocation
0285179 
Signed-off-by: Paul Barker <paul@pbarker.dev>
Ref: #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
The Plan
Status: In Progress
Milestone
mirrorshades v0.3.0
Development

No branches or pull requests
1 participant
@pbrkr