feat(core, preset-mini): generate preflights on demand #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
commit: |
antfu
reviewed
Nov 6, 2024
zyyv
commented
Nov 25, 2024
antfu
reviewed
Nov 29, 2024
packages/core/src/config.ts
Outdated
| }) | ||
| // delete static rules so we can't skip them in matching | ||
| // but keep the order | ||
| return undefined | ||
| } | ||
| return [i, ...rule] | ||
| return [i, rule[0], rule[1], rule[2], rule] |
There was a problem hiding this comment.
I wonder if we can just return [i, rule], or even the i is not needed?
There was a problem hiding this comment.
I made a PR to this branch with #4304
Seems to work fine?
antfu
approved these changes
Nov 30, 2024
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3521
InRulemeta, specify thepreflight keyyou need to depend on and generate preflights on demand. This will reduce irrelevant CSS output.