-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improving Neumorphic ToggleSwitch #1044
base: master
Are you sure you want to change the base?
Conversation
79e5895
to
bdc4dd1
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net |
@kazo0, @eriklimakc, @Xiaoy312 Can you help test the stage site page of this PR please |
@morning4coffe-dev can you help qa/test the static web app link + changes locally to see if you can reproduce the issues I am seeing on the static web app link on my side please |
@agneszitte @eriklimakc Both locally on WASM and on the static web app, I can see similar behavior. When I try to open the ComboBox for neum. styles, the UI dissapears for me. For both tests using Edge latest stable. LocalRecording.2024-06-10.232027.mp4AzureRecording.2024-06-10.231021.mp4 |
Thank you a lot for the test @morning4coffe-dev, is this also happening on latest master please? or it is just related to this PR ? |
@agneszitte I tried to check with all the controls in the ComboBox, but I can't reporduce this Issue on latest master. The UI renders normally: |
@eriklimakc I switched this PR as Draft until it is figured out what is happening with the current changes here based on the latest feedback from @morning4coffe-dev that it does not happen on latest master. |
bdc4dd1
to
833c01d
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net |
@morning4coffe-dev @agneszitte I rebased from master and I couldn't reproduce it anymore. Could be that some of the changes made in master fixed it? Can you please retest it? |
@eriklimakc @agneszitte Jup, I can't no longer reproduce it either on this branch: |
@eriklimakc and @morning4coffe-dev I am not able to reproduce the issue either now when testing the static web app link associated with the PR. |
GitHub Issue (If applicable): closes #1033 and #1034
PR Type
What kind of change does this PR introduce?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements: