Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix build errors in RadioButton UI tests #1115

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Project automation
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 requested a review from Darsh0307 June 3, 2024 20:49
@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch from 5bffd53 to 0200e5c Compare June 3, 2024 20:52
Copy link

github-actions bot commented Jun 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Jun 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@jeromelaban
Copy link
Member

The good news is that some tests are passing, but the simulator likely needs to change:

public readonly static string iOSDeviceNameOrId = "iPad Pro (12.9-inch) (5th generation)";

Likely to a 6th generation, where it will otherwise choose the default emulator (a small iPhone, in general).

Copy link

github-actions bot commented Jun 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch from 46cd2e6 to 44296d3 Compare June 4, 2024 10:39
@Youssef1313
Copy link
Member Author

Issues don't seem related to simulator size 😕

Most (if not all) of the failing tests were never validated on CI before, they were written after the CI broke. Some tests may be just flaky, some may be consistent failures. For now, I think it's best to get this merged as soon as possible so will probably be skipping some of the tests 😕

Copy link

github-actions bot commented Jun 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch from 44296d3 to 8145522 Compare June 4, 2024 12:30
Copy link

github-actions bot commented Jun 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch from 8145522 to 1ca1bfd Compare June 4, 2024 19:56
Copy link

github-actions bot commented Jun 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@agneszitte agneszitte requested a review from kazo0 June 4, 2024 23:58
@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch 2 times, most recently from f9d3794 to c946ac5 Compare June 5, 2024 01:52
Copy link

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch from c946ac5 to af3d9ee Compare June 5, 2024 03:24
@Youssef1313 Youssef1313 force-pushed the dev/youssef/uitest branch from af3d9ee to dc65058 Compare June 5, 2024 03:25
Copy link

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

1 similar comment
Copy link

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1115.eastus2.3.azurestaticapps.net

@Youssef1313
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MartinZikmund MartinZikmund merged commit 7a3cf4a into master Jun 5, 2024
16 checks passed
@MartinZikmund MartinZikmund deleted the dev/youssef/uitest branch June 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants