-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing XAML editor to use Monaco editor #140
Changing XAML editor to use Monaco editor #140
Conversation
@carldebilly let me know what you think. I think before this PR is merged, it would be good to work out how the monaco editor files could be included in the MonacoEditorComponet, rather than explicitly added as source code. |
Adding Uno.Monaco.Editor nuget package
@carldebilly I've fixed up the Uno.Monaco.Editor nuget package so we don't need to include all the monaco source files here (or anywhere else that wants to use the Monaco Editor) |
Intellisense - I've only added TextBlock but we can easily add any of the XAML elements Error highlighting works - Only issue is that the XAML parser doesn't seem to be that accurate with where the errors actually are, so perhaps a bit of refinement to be done but at least the user sees the marking in the right spot
|
@nickrandolph amazing! |
@nickrandolph loving this !!Very nice work :) |
Is not working in the current version :-( I figured out, I have to desantize the result : |
GitHub Issue (If applicable): #139
PR Type
What kind of change does this PR introduce?
What is the current behavior?
XAML editor is simple textbox
What is the new behavior?
XAML editor uses the Monaco editor which can provide intellisense and code highlighting
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):