Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Bump SDK to include Xcode15 vs NewsstandKit fix #180

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot commented Oct 7, 2023

With this newer SDK there's a workaround for the issue.

Before

/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : clang exited with code 1: [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : In file included from /Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/obj/Debug/net7.0-ios/iossimulator-x64/linker-cache/registrar.mm:3: [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : /Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/obj/Debug/net7.0-ios/iossimulator-x64/linker-cache/registrar.h:34:9: fatal error: 'NewsstandKit/NewsstandKit.h' file not found [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : #import <NewsstandKit/NewsstandKit.h> [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error :         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : 1 error generated. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]

After

ILLINK : warning MT4178: The class 'NewsstandKit.NKAssetDownload' will not be registered because the NewsstandKit framework has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4178: The class 'NewsstandKit.NKLibrary' will not be registered because the NewsstandKit framework has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4189: The class 'PassKit.PKDisbursementAuthorizationControllerDelegate' will not be registered it has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4178: The class 'NewsstandKit.NKIssue' will not be registered because the NewsstandKit framework has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4189: The class 'PassKit.PKDisbursementAuthorizationController' will not be registered it has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]

With this newer SDK there's a workaround for the issue.

Before
```
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : clang exited with code 1: [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : In file included from /Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/obj/Debug/net7.0-ios/iossimulator-x64/linker-cache/registrar.mm:3: [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : /Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/obj/Debug/net7.0-ios/iossimulator-x64/linker-cache/registrar.h:34:9: fatal error: 'NewsstandKit/NewsstandKit.h' file not found [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : #import <NewsstandKit/NewsstandKit.h> [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error :         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
/usr/local/share/dotnet/packs/Microsoft.iOS.Sdk/16.4.7098/targets/Xamarin.Shared.Sdk.targets(1139,3): error : 1 error generated. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
```

After
```
ILLINK : warning MT4178: The class 'NewsstandKit.NKAssetDownload' will not be registered because the NewsstandKit framework has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4178: The class 'NewsstandKit.NKLibrary' will not be registered because the NewsstandKit framework has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4189: The class 'PassKit.PKDisbursementAuthorizationControllerDelegate' will not be registered it has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4178: The class 'NewsstandKit.NKIssue' will not be registered because the NewsstandKit framework has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
ILLINK : warning MT4189: The class 'PassKit.PKDisbursementAuthorizationController' will not be registered it has been removed from the iOS SDK. [/Users/poupou/git/spouliot/templates/uno/4.9.0-dev.164/unoapp/unoapp.Mobile/unoapp.Mobile.csproj::TargetFramework=net7.0-ios]
```
@spouliot spouliot requested a review from jeromelaban October 7, 2023 20:42
@nickrandolph nickrandolph merged commit 154f3fa into main Oct 8, 2023
30 checks passed
@nickrandolph nickrandolph deleted the fix-xcode15-newstandskit branch October 8, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants