Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Testharness for windows #2561

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix: Testharness for windows #2561

merged 4 commits into from
Sep 23, 2024

Conversation

Kunal22shah
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@kazo0 kazo0 merged commit cd193dc into main Sep 23, 2024
14 of 15 checks passed
@kazo0 kazo0 deleted the dev/nr/msalwinuiredirect branch September 23, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklimakc eriklimakc eriklimakc approved these changes

@kazo0 kazo0 kazo0 approved these changes

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kunal22shah @kazo0 @eriklimakc @nickrandolph