Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not set on WinUI window #129

Closed
nickrandolph opened this issue May 8, 2023 · 1 comment · Fixed by unoplatform/uno.templates#108, #133 or #137
Closed

Icon not set on WinUI window #129

nickrandolph opened this issue May 8, 2023 · 1 comment · Fixed by unoplatform/uno.templates#108, #133 or #137
Assignees

Comments

@nickrandolph
Copy link
Contributor

nickrandolph commented May 8, 2023

The .ico file is being created for WinUI but isn't being set on the ApplicationIcon property, so results in the default icon

@nickrandolph nickrandolph self-assigned this May 8, 2023
nickrandolph referenced this issue in unoplatform/uno.templates May 8, 2023
@nickrandolph nickrandolph transferred this issue from unoplatform/uno.templates May 8, 2023
@nickrandolph nickrandolph assigned pictos and unassigned nickrandolph May 8, 2023
@pictos
Copy link
Contributor

pictos commented May 8, 2023

I tried to add the ico file directly to the project, so the Resizetizer will not handle that... And the icon didn't show on window. So I'm wondering if there's one more step, on winUI itself, to make that ico visible.

<PropertyGroup>
		<ApplicationIcon>iconapp.ico</ApplicationIcon>
</PropertyGroup>

here's the branch with the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants