fix: Icon not set on WinUI window #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
May 8, 2023
|
Converting this to draft. I don't really love having this code in the template. Let's come up with a better spec to handle this and figure out where it should live and how it should be called. |
|
Reopened as draft as we need to change the implementation to call generated code from Resizetizer |
|
Blocked waiting for this PR to complete: unoplatform/uno.resizetizer#133 |
nickrandolph
added
the
do-not-merge/work-in-progress
Fixes #107
nickrandolph
force-pushed
the
dev/nr/issue107
branch
from
efd37e6
to
bd30e64
Compare
nickrandolph
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes unoplatform/uno.resizetizer#129
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Icon not set for WinUI
What is the new behavior?
Icon set
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):