Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WasmPWAManifestFile is not overriden properly #303

Closed
jeromelaban opened this issue Jul 11, 2024 · 1 comment · Fixed by #305
Closed

WasmPWAManifestFile is not overriden properly #303

jeromelaban opened this issue Jul 11, 2024 · 1 comment · Fixed by #305
Assignees
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@jeromelaban
Copy link
Member

Current behavior

The manifest used in the index.html points to a file that does not exist:

image

image

Expected behavior

The WasmPWAManifestFile property should be overriden by resizetizer before BuildDist.

@jeromelaban jeromelaban added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Jul 11, 2024
@jeromelaban
Copy link
Member Author

Portion of the fix:

  <Target Name="_adjustJson" BeforeTargets="BuildDist">
    <PropertyGroup>
      <WasmPWAManifestFile>$(_UnoIntermediateAppIcon)/Unomanifest.webmanifest</WasmPWAManifestFile>
    </PropertyGroup>
  </Target>

Also, $(_UnoIntermediateAppIcon)/Unomanifest.webmanifest should not be set as Content, as the bootstrapper automatically copies the file at the root of the resulting dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants