Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Override WasmPWAManifestFile properly #305

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix: Override WasmPWAManifestFile properly #305

merged 3 commits into from
Jul 16, 2024

Conversation

ebariche
Copy link
Member

Fixes: #303

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@ebariche ebariche force-pushed the dev/eb/manifest branch 2 times, most recently from 3764d3f to c7f972f Compare July 15, 2024 20:27
@ebariche ebariche marked this pull request as ready for review July 15, 2024 20:59
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/1.5

Copy link

mergify bot commented Jul 15, 2024

backport release/stable/1.5

✅ Backports have been created

@ebariche ebariche added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@ebariche ebariche marked this pull request as draft July 15, 2024 21:37
@ebariche ebariche removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@ebariche ebariche marked this pull request as ready for review July 15, 2024 23:59
@ebariche ebariche merged commit ab50fa3 into main Jul 16, 2024
10 checks passed
@ebariche ebariche deleted the dev/eb/manifest branch July 16, 2024 00:03
Copy link

welcome bot commented Jul 16, 2024

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

jeromelaban added a commit that referenced this pull request Jul 16, 2024
…5/pr-305

fix: Override WasmPWAManifestFile properly (backport #305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WasmPWAManifestFile is not overriden properly
3 participants