Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all cultures works (backport #101) #116

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Make sure all cultures works (backport #101) #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Resizetizer/src/ResizeImageInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Globalization;
using System.IO;
using Microsoft.Build.Framework;
using SkiaSharp;
Expand Down Expand Up @@ -61,11 +62,11 @@ private static bool IsVectorFilename(string? filename)
public static ResizeImageInfo Parse(ITaskItem image)
=> Parse(new[] { image })[0];

public static List<ResizeImageInfo> Parse(IEnumerable<ITaskItem> images)
public static List<ResizeImageInfo> Parse(IEnumerable<ITaskItem>? images)
{
var r = new List<ResizeImageInfo>();

if (images == null)
if (images is null)
return r;

foreach (var image in images)
Expand Down Expand Up @@ -115,7 +116,7 @@ public static List<ResizeImageInfo> Parse(IEnumerable<ITaskItem> images)
if (bool.TryParse(image.GetMetadata("IsAppIcon"), out var iai))
info.IsAppIcon = iai;

if (float.TryParse(image.GetMetadata("ForegroundScale"), out var fsc))
if (float.TryParse(image.GetMetadata("ForegroundScale"),NumberStyles.Number, CultureInfo.InvariantCulture, out var fsc))
info.ForegroundScale = fsc;

var fgFile = image.GetMetadata("ForegroundFile");
Expand Down