Improved UnoSplashScreen Target #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #134
What is the current behavior?
Actually the
ProcessUnoSplashScreencreates the splash assets and consumes/process them, when nothing changed this target is skipped, which can cause the splash screen to not be included on the app. That was noted and fixed by for wasm by #127, but we shouldn't remove theInputandOutputin order to fix that.What is the new behavior?
Now we have a new target called
GenerateUnoSplashScreensthat will be responsible to create all the assets needed by the platforms, and to consume/process these assets we will useProcessUnoSplashScreenthat will always run.Other information
In order to make those changes easier to review and small, will be more PR addressing improving other parts. Right now, we can note an error on incremental builds on UnoIcon for wasm and Skia targets, which will be fixed in future iterations.
Because of that those PRs will target a separated branch
pj/build-task-updateand at the end will be merged againstmain